Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Time#clone #4174

Merged
merged 2 commits into from
Mar 23, 2017
Merged

Implement Time#clone #4174

merged 2 commits into from
Mar 23, 2017

Conversation

Sija
Copy link
Contributor

@Sija Sija commented Mar 22, 2017

ATM you can't #clone any Tuple or NamedTuple including Time instance.
This PR adds #clone method to Time (calls #dup internally).

bcardiff
bcardiff requested changes Mar 22, 2017
View reviewed changes
Copy link
Member

@bcardiff bcardiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(see comment inline)

In a more general case, this happen for all structs that does not have clone, yet I don't see a problem to allow clone by default on structs. But we can discuss address/discuss that in other PR/issue.

@Sija Sija mentioned this pull request Mar 23, 2017
Closed
@bcardiff
Copy link
Member

@Sija I just realized that my inline comment was never sent. I made a little change. After that we should be able to merge it.

@bcardiff bcardiff added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib labels Mar 23, 2017
@bcardiff bcardiff added this to the Next milestone Mar 23, 2017
@bcardiff bcardiff merged commit 204c94c into crystal-lang:master Mar 23, 2017
@asterite asterite mentioned this pull request Mar 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardiff bcardiff bcardiff requested changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib
Projects
None yet
Milestone
0.22.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Sija @bcardiff