crystal --version reports LLVM_VERSION
#4095
Conversation
| else | ||
| "Crystal #{version} (#{date})" | ||
| "Crystal #{version} (#{date}) LLVM #{llvm_version}" |
There was a problem hiding this comment.
Maybe put it on a new line?
Crystal 0.21.0 (2017-02-20)
LLVM 4.0
My thinking is that it would make it easier to report other info in the future (stick each item on a new line).
There was a problem hiding this comment.
I thought about that - a little bit inspired in docker version - but I couldn't come with any other thing I wanted to see reported there.
I thought maybe a Crystal program would specify this versions in it's own --version command - say, running my-tool --version would report both my-tool's, Crystal's & LLVM's versions, but @asterite somewhat convinced me you shouldn't care about LLVM version in client code (btw, do you agree with this?).
I'm open to change my mind, anyway :)
There was a problem hiding this comment.
I think one line is fine for now. Maybe we can discuss the general output of crystal version in another issue :-)
This PR makes
crystal --versionreport the LLVM version the compiler is using. It also adds aCrystal::LLVM_VERSIONconstant that user code can access, analogous toCrystal::VERSION.Hopefully, it will help troubleshoot compiler bugs that are related to changes in LLVM versions.