Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add man page to crystal #2989

Merged
merged 19 commits into from
May 23, 2017
Merged

Add man page to crystal #2989

merged 19 commits into from
May 23, 2017

Conversation

do-you-dare
Copy link
Contributor

@do-you-dare do-you-dare commented Jul 13, 2016

@werner started this, I'm starting from where he left. Any comments are welcome.

Closes #1291.

Show version.
.El
.Sh SEE ALSO
.Bl -hang -compact -width "https://github.com/manastech/crystal/1234"
Copy link
Member

@jhass jhass Jul 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outdated URLs Also not sure what's this about

@do-you-dare
Copy link
Contributor Author

I've made a bunch of changes. Is there something more you would like to see here?

@@ -0,0 +1,230 @@
.\"Crystal Programming Language
.Dd March 7, 2016
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just get rid of the date.

@jhass
Copy link
Member

jhass commented Jul 31, 2016

... and so on. That would be the minimum level of verbosity I would expect from a manpage, to have a benefit over --help.

.El
.Sh SEE ALSO
.Fn shards 1
.Bl -hang -compact -width "https://github.com/crystal-lang/crystal/1234"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line appears to have no purpose as it does not display, and the link goes nowhere.

Copy link
Contributor Author

@do-you-dare do-you-dare Oct 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The url really doesn't display; it is the argument for width. The url itself is not important, just its length. I can change this, if you want.
The line itself has purpose; it starts a block with .Bl with the same width as the dummy url.

@Sija
Copy link
Contributor

Sija commented Jan 6, 2017

Any progress here, @jhass?

@RX14
Copy link
Contributor

RX14 commented May 17, 2017

Perhaps we can merge this so we have a man page for others to fix up and contribute to instead of being forever stalled.

@mverzilli mverzilli merged commit ac6deff into crystal-lang:master May 23, 2017
@mverzilli
Copy link

Thank you @dread-uo and everyone who reviewed! It took us a bit long, but here we are :).

@mverzilli mverzilli added this to the Next milestone May 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants