We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently, the formatter always leaves SymbolLiterals in the source code unchanged:
SymbolLiteral
crystal/src/compiler/crystal/tools/formatter.cr
Lines 444 to 450 in 752c57b
This means all of the following symbols remain after formatting, even though they are equal to each other:
:foo :"foo" :"fo\o" # invalid escape
Other similar fragments with redundant quotation marks that the formatter doesn't remove are:
def foo("x" y) end foo("x": 1) NamedTuple("x": Int32) {"x": 1}
Unifying these forms to the quoteless variant is desirable as it simplifies source code searching. This means:
Note that macro interpolation already applies the first two normalizations to all those fragments already.
The text was updated successfully, but these errors were encountered:
I want to give this a shot.
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
Currently, the formatter always leaves
SymbolLiteral
s in the source code unchanged:crystal/src/compiler/crystal/tools/formatter.cr
Lines 444 to 450 in 752c57b
This means all of the following symbols remain after formatting, even though they are equal to each other:
Other similar fragments with redundant quotation marks that the formatter doesn't remove are:
Unifying these forms to the quoteless variant is desirable as it simplifies source code searching. This means:
Note that macro interpolation already applies the first two normalizations to all those fragments already.
The text was updated successfully, but these errors were encountered: