We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File#read_at
Currently https://github.com/crystal-lang/crystal/blob/master/src/file/preader.cr#L7's ivars are typed as Int32, this prevents reading a large enough file at points greater than Int32::Max.
Int32
Int32::Max
Similarly, thoughts on making bytesize be nilable? This would support the use case of "read the remainder of a file starting at offset x" when using https://crystal-lang.org/api/master/File.html#read_at(offset,bytesize,&)-instance-method.
bytesize
The text was updated successfully, but these errors were encountered:
Yes for the first thing, I don't know about the second one, maybe it's okay.
Sorry, something went wrong.
IO#read_at
Successfully merging a pull request may close this issue.
Currently https://github.com/crystal-lang/crystal/blob/master/src/file/preader.cr#L7's ivars are typed as
Int32
, this prevents reading a large enough file at points greater thanInt32::Max
.Similarly, thoughts on making
bytesize
be nilable? This would support the use case of "read the remainder of a file starting at offset x" when using https://crystal-lang.org/api/master/File.html#read_at(offset,bytesize,&)-instance-method.The text was updated successfully, but these errors were encountered: