From 836a51b265be0ad62191d49a6fd4f63ce2d013a7 Mon Sep 17 00:00:00 2001
From: Julien Portalier <julien@portalier.com>
Date: Thu, 9 Jan 2025 14:09:41 +0100
Subject: [PATCH] LLVM optimization: reduce complexity at call site

@BlobCodes: I think it would be better to print the bug message in
`Crystal.once` instead of `__crystal_once` to reduce complexity at the
callsite. The previous unreachable method can then be used in the
inlined `__crystal_once` so LLVM also knows it doesn't have to re-run
the method.

It's now even safe because `Crystal.once` would panic if it failed; it
should already be impossible, but let's err on the safe side.
---
 src/crystal/once.cr | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

diff --git a/src/crystal/once.cr b/src/crystal/once.cr
index 8b68a78dd3b8..0460a82d0f6b 100644
--- a/src/crystal/once.cr
+++ b/src/crystal/once.cr
@@ -39,6 +39,13 @@
       {% else %}
         once_exec(flag, initializer)
       {% end %}
+
+      # safety check, and allows to safely call `#once_unreachable` in
+      # `__crystal_once`
+      unless flag.value.initialized?
+        System.print_error "BUG: failed to initialize constant or class variable\n"
+        LibC._exit(1)
+      end
     end
 
     private def self.once_exec(flag : OnceState*, initializer : Void*) : Nil
@@ -54,10 +61,10 @@
       end
     end
 
-    @[NoInline]
+    @[AlwaysInline]
     def self.once_unreachable : NoReturn
-      System.print_error "BUG: failed to initialize constant or class variable\n"
-      LibC._exit(1)
+      x = uninitialized NoReturn
+      x
     end
   end
 
@@ -79,8 +86,9 @@
 
     Crystal.once(flag, initializer)
 
-    # make LLVM assume that it musn't call `__crystal_once` anymore for this,
-    # also doubles as a safety check
+    # tell LLVM that it can optimize away repeated `__crystal_once` calls for
+    # this global (e.g. repeated access to constant in a single funtion);
+    # this is truly unreachable otherwise `Crystal.once` would have panicked
     Crystal.once_unreachable unless flag.value.initialized?
   end
 {% else %}