-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support highlighting of lambda params? #8
Comments
Edit: see comments below.
It depends of theme, this extension already has parameter support. <- Not true
Currently I'm using https://marketplace.visualstudio.com/items?itemName=faustinoaq.theme-olivine-comments to get good crystal highlighting. <- Not solution
…On Sat, Jul 29, 2017 at 12:36 AM, Hanyuan Li ***@***.***> wrote:
Maybe support highlighting of this:
[1, 2, 3].map { |a| a + 1 }
The a in |a| should be highlighted as a parameter.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/faustinoaq/vscode-crystal-lang/issues/8>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AC7Nx6Fee4hIpr1BgwZmLnRY0_hzIEQgks5sSsTcgaJpZM4OnQ5X>
.
|
Shouldn't it be highlighted in the same way as a parameter, though? Why is there a need for two highlighting methods? I'm using VS Code's Monokai, and I don't see the highlighting. |
~~Unless I change this line to Ruby, other VSCode themes does't recognize the crystal delimiter.~~~ "begin": "(?<=\\{|do|\\{\\s|do\\s)(\\|)",
"captures": {
"1": {
"name": "punctuation.separator.variable.crystal"
}
}, Edit: see comment below |
I found a lot of dirty code when I converted I'll do a PR fixing this issue. Internally related to #7 |
Fixed on #9 |
Support highlighting of this:
The
a
in|a|
should be highlighted as a parameter.The text was updated successfully, but these errors were encountered: