Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Include evm_log_handlers errors in ethereum logs #61

Closed
thomas-nguy opened this issue Sep 9, 2021 · 3 comments
Closed

Problem: Include evm_log_handlers errors in ethereum logs #61

thomas-nguy opened this issue Sep 9, 2021 · 3 comments
Labels
evm This issue or PR is related to EVM help wanted Extra attention is needed

Comments

@thomas-nguy
Copy link
Collaborator

The evm hook allows us to process logs from an ethereum transaction.

I would be nice that the details of the evm_log_handlers.go errors would also appear on eth logs or returned to the client so that he would be aware why the transaction fails

@tomtau tomtau added help wanted Extra attention is needed evm This issue or PR is related to EVM labels Oct 28, 2021
@tomtau
Copy link
Contributor

tomtau commented Oct 28, 2021

I guess these details would go into DeliverTx fields such as "logs" that aren't a part of the consensus data, right?

@thomas-nguy
Copy link
Collaborator Author

thomas-nguy commented Oct 28, 2021

yeah, having the error failure message in evm logs would mostly be beneficial for the indexer and web3 users since they are using the transaction receipt to check the result of their transactions.

for now, they only get a generic internal error message when the hook fails

@yihuang
Copy link
Collaborator

yihuang commented Mar 9, 2022

The "internal" error message has been fixed by this PR: evmos/ethermint#786.
In 0.7.0, the client should see "failed to execute post processing" if tx failed in hooks.

@yihuang yihuang closed this as completed Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
evm This issue or PR is related to EVM help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants