This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Problem: block id field in vote could be empty #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: - Fix the problem in tendermint-rs - upgrade dependency
yihuang
requested review from
calvinaco,
devashishdxt and
tomtau
as code owners
|
thanks! |
Codecov Report
@@ Coverage Diff @@
## master #737 +/- ##
==========================================
- Coverage 69.69% 69.68% -0.02%
==========================================
Files 131 131
Lines 16749 16749
==========================================
- Hits 11674 11672 -2
- Misses 5075 5077 +2
|
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 25, 2019
737: Problem: block id field in vote could be empty r=devashishdxt a=yihuang Solution: - Fix the problem in tendermint-rs - Upgrade dependency tendermint-rs PR for this: informalsystems/tendermint-rs#103 Co-authored-by: yihuang <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
tendermint-rs PR for this: informalsystems/tendermint-rs#103