Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Refactor drag and drop code so that DashboardCard order does not depend on DOM element order #871

Open
maxcao13 opened this issue Feb 10, 2023 · 0 comments
Labels
chore Refactor, rename, cleanup, etc.

Comments

@maxcao13
Copy link
Member

Also, i noticed that iframeare being reinitialized when reordering. Came across this one

It is indeed slightly annoying, but only because the re-ordering functionality is tied in with the order that the card elements are being attached to the DOM. It doesn't have to actually be this way since Patternfly grid uses the grid-order for its ordering which is just a css attribute, however I implemented the drag drop keeping the JS list order in mind which it is just a bit more intuitive. There will just need to a bit of refactoring with how the drag and drop works, but its probably not horrible. If you guys think this is important, I will look into a patch.

Originally posted by @maxcao13 in #856 (comment)

@maxcao13 maxcao13 moved this to Todo in 2.3.0 release Feb 10, 2023
@maxcao13 maxcao13 added the chore Refactor, rename, cleanup, etc. label Feb 10, 2023
@andrewazores andrewazores moved this from Todo to Stretch Goals in 2.3.0 release Feb 10, 2023
@andrewazores andrewazores moved this from Stretch Goals to Pushed to 2.4.0 in 2.3.0 release Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc.
Projects
No open projects
Status: Pushed to 2.4.0
Development

No branches or pull requests

1 participant