Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Application startup tasks can block the Vertx event loop #1661

Open
andrewazores opened this issue Sep 7, 2023 · 0 comments
Open

[Bug] Application startup tasks can block the Vertx event loop #1661

andrewazores opened this issue Sep 7, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@andrewazores
Copy link
Member

          Vertx's default setting is to have `cpuCores * 2` threads in the pool, so definitely adding a bunch of extra threads here like this is going to increase the size of the pool substantially for most deployments. The proper fix would be to avoid doing blocking work on startup, or at least move that blocking work off of a Vertx event loop thread, but that's a relatively deep change and I haven't had enough time to look into it yet. If I have time before the next 2.4 release I will, but it seems riskier to do that than to simply bump up the minimum pool size a bit for now.

Originally posted by @andrewazores in https://github.com/cryostatio/cryostat/pull/1650#discussion_r1318986255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant