-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
loop performance optimizations / 1 #3313
Conversation
@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3313 +/- ##
=======================================
Coverage 58.45% 58.45%
=======================================
Files 351 351
Lines 37801 37818 +17
=======================================
+ Hits 22096 22107 +11
- Misses 13803 13809 +6
Partials 1902 1902
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f5d30b8
to
631aa00
Compare
631aa00
to
3d1be7e
Compare
3d1be7e
to
ef270e0
Compare
this linter prevents the copy of big struct elements in loops over slices or maps
how often the loop is executed, or how many iterations, is not taken in consideration by the linter - many cases are not a performance issue but there's no downside in fixing them except for the minor convenience of access-by-index