Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different parsing of docker-compose environment variables #2051

Closed
Typhonragewind opened this issue Feb 10, 2023 · 2 comments
Closed

Different parsing of docker-compose environment variables #2051

Typhonragewind opened this issue Feb 10, 2023 · 2 comments
Assignees
Labels
kind/bug Something isn't working needs/triage

Comments

@Typhonragewind
Copy link

What happened?

I've updated my edge Crowdsec installation to version 1.4.6, which is configured to communicate my main server (which handles the LAPI). This configuration has been working great, but it failed to start with the update.
After some troubleshooting I managed to identify and fix the issue, and I'm posting this in case other people face the same issue

From the log, it seemed to be an error in parsing the LAPI url because of a colon:

level=fatal msg="starting outputs error : parsing api url ('\"http://mainserver.backhaul:25698\"/'): parse \"\\\"http://mainserver.backhaul:25698\\\"/\": first path segment in URL cannot contain colon: parse \"\\\"http://mainserver.backhaul:25698\\\"/\": first path segment in URL cannot contain colon"

After checking my docker-compose file I noticed that in the past i had enclosed the LAPI URL (and other) variable value in double quotes (because I'm paranoid). After removing them, the container starts and works as normal.

However, this behaviour is different than in the past versions, which accepted the double quotes. You might want to post a more specific warning about this one somewhere in the documentation.

What did you expect to happen?

Container to start up normally

How can we reproduce it (as minimally and precisely as possible)?

Update crowdsec to most recent version (1.4.6) and start a container in which an environment variable has a value that contains quotes or double quotes enclosing the value

Anything else we need to know?

No response

Crowdsec version

1.4.6

OS version

# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here

Enabled collections and parsers

$ cscli hub list -o raw
# paste output here

Acquisition config

```console # On Linux: $ cat /etc/crowdsec/acquis.yaml /etc/crowdsec/acquis.d/* # paste output here

On Windows:

C:> Get-Content C:\ProgramData\CrowdSec\config\acquis.yaml

paste output here

Config show

$ cscli config show
# paste output here

Prometheus metrics

$ cscli metrics
# paste output here

Related custom configs versions (if applicable) : notification plugins, custom scenarios, parsers etc.

@Typhonragewind Typhonragewind added the kind/bug Something isn't working label Feb 10, 2023
@github-actions
Copy link

@Typhonragewind: Thanks for opening an issue, it is currently awaiting triage.

In the meantime, you can:

  1. Check Crowdsec Documentation to see if your issue can be self resolved.
  2. You can also join our Discord.
  3. Check Releases to make sure your agent is on the latest version.
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc self-assigned this Feb 13, 2023
@LaurenceJJones
Copy link
Contributor

Hey 👋🏻

Apologies for no reply, it has been sometime since the issue was opened, I tried to track down from 1.4.X to 1.5.X if we changed the behavior, which between these versions we made alot of changes to the startup script. I will class the issue as completed, as we have stabilized the docker startup script now so dont expect any changes that may cause this issue again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working needs/triage
Projects
None yet
Development

No branches or pull requests

3 participants