Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task add command: deprecate --[no-]skip-untranslated-strings #851

Closed
andrii-bodnar opened this issue Oct 8, 2024 · 0 comments · Fixed by #860
Closed

task add command: deprecate --[no-]skip-untranslated-strings #851

andrii-bodnar opened this issue Oct 8, 2024 · 0 comments · Fixed by #860
Labels
good first issue hacktoberfest This issue welcomes contributions for Hacktoberfest

Comments

@andrii-bodnar
Copy link
Member

The Skip untranslated strings option for creating tasks is deprecated and will be removed in the future. We need to deprecate the corresponding parameter in the task add command.

The --[no-]skip-untranslated-strings should still work but needs to be removed from the crowdin task add -h help screen and documentation.

If the user passes this parameter, we should display a deprecation warning.

References:
@andrii-bodnar andrii-bodnar added good first issue hacktoberfest This issue welcomes contributions for Hacktoberfest labels Oct 8, 2024
@andrii-bodnar andrii-bodnar changed the title task add command: deprecate --[no-]skip-untranslated-strings task add command: deprecate --[no-]skip-untranslated-strings Oct 8, 2024
@andrii-bodnar andrii-bodnar linked a pull request Oct 24, 2024 that will close this issue
feat: deprecate skip-untranslated-strings for task add command #860
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue hacktoberfest This issue welcomes contributions for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: deprecate skip-untranslated-strings for task add command crowdin/crowdin-cli
1 participant
@andrii-bodnar