Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more Unit tests for the core package #191

Closed
andrii-bodnar opened this issue Sep 28, 2023 · 9 comments · Fixed by #243
Closed

Add more Unit tests for the core package #191

andrii-bodnar opened this issue Sep 28, 2023 · 9 comments · Fixed by #243
Assignees
@DecarteAdam
Labels
good first issue Good for newcomers hacktoberfest This issue welcomes contributions for Hacktoberfest

Comments

@andrii-bodnar
Copy link
Member

The core package has low code coverage by Unit tests. We need to add more Unit tests to cover the code.

References:
@andrii-bodnar andrii-bodnar added enhancement New feature or request good first issue Good for newcomers hacktoberfest This issue welcomes contributions for Hacktoberfest and removed enhancement New feature or request labels Sep 28, 2023
@andrii-bodnar andrii-bodnar changed the title Add more Unit tests for the core package Add more Unit tests for the core package Sep 28, 2023
@debanjanc01
Copy link

Hey @andrii-bodnar I can pick this up.

@andrii-bodnar
Copy link
Member Author

Hi @debanjanc01, any updates on this?

@debanjanc01
Copy link

Hey @andrii-bodnar , I'm still working on it, although my speed has been super slow.

@debanjanc01 debanjanc01 removed their assignment Oct 17, 2023
@debanjanc01
Copy link

Hey @andrii-bodnar I'm unassigning myself in case someone else wants to pick this up. I'm not getting the time lately to polish my changes and push them.

@DecarteAdam
Copy link
Contributor

Hi,
What is expected code coverage?

@andrii-bodnar
Copy link
Member Author

@DecarteAdam I think that around 80-90% for the core package would be good

@DecarteAdam
Copy link
Contributor

Hi @andrii-bodnar ,
I've just pushed.
Can you assign this to me pls ?

@DecarteAdam
Copy link
Contributor

Hey @andrii-bodnar can you link this issue to my PR?

@andrii-bodnar andrii-bodnar linked a pull request May 6, 2024 that will close this issue
test: add Unit Tests to core package #243
Merged
@andrii-bodnar
Copy link
Member Author

Hey @DecarteAdam, thank you!

Will review it soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DecarteAdam DecarteAdam

Labels
good first issue Good for newcomers hacktoberfest This issue welcomes contributions for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: add Unit Tests to core package DecarteAdam/crowdin-api-client-java
3 participants
@andrii-bodnar @debanjanc01 @DecarteAdam