Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Revisit/test common controller after final tfcli implementation #37

Closed
turkenh opened this issue Aug 26, 2021 · 2 comments
Closed

Revisit/test common controller after final tfcli implementation #37

turkenh opened this issue Aug 26, 2021 · 2 comments
Assignees
Labels
alpha enhancement New feature or request

Comments

@turkenh
Copy link
Member

turkenh commented Aug 26, 2021

What problem are you facing?

The common controller is a layer sitting between generated schema and async terraform CLI library, mostly dealing with conversions between crossplane/terraform and proper implementation of crossplane managed reconciler interface functions.

The current implementation is mostly tested with some early implementations (open PRs, assumptions) and happy path scenarios (mostly with AWS VPC).

How could Terrajet help solve your problem?

We would need to revisit the existing implementation with more resources and edge-case scenarios.
Another point is, implementation of this layer could be affected by the output of this discussion, hence it might make sense to consider that while working here.

@turkenh turkenh added the enhancement New feature or request label Aug 26, 2021
@turkenh turkenh self-assigned this Aug 26, 2021
@ulucinar
Copy link
Collaborator

I have tested successfully CRUD operations using common controller on top of #3.

Albeit somewhat slow (because we are waiting for terraform, and because we are not polling frequent enough), I have been successfully provision an AWS VPC, observe it in ready state, update its tags, and delete it via its MR.

@turkenh
Copy link
Member Author

turkenh commented Sep 9, 2021

Closing in favor of #55

@turkenh turkenh closed this as completed Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
alpha enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants