Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MSSQLServerDNSAlias and add examples #58

Closed
wants to merge 1 commit into from

Conversation

turkenh
Copy link
Contributor

@turkenh turkenh commented Oct 18, 2022

Description of your changes

This PR fixes #27 with the fix implemented in the native terraform provider by updating to the latest version, i.e. v3.27.0. It also adds examples to have it tested with automation.

Fixes #27

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

make uptest-local EXAMPLE_LIST=examples/sql/mssqlserverdnsalias.yaml
kubectl get managed
NAME                                                           READY   SYNCED   EXTERNAL-NAME                   AGE
resourcegroup.azure.upbound.io/example-dns-alias-op-antar2xe   True    True     example-dns-alias-op-antar2xe   6m22s

NAME                                                         READY   SYNCED   EXTERNAL-NAME       AGE
mssqlserverdnsalias.sql.azure.upbound.io/example-dns-alias   True    True     example-dns-alias   6m23s

NAME                                                     READY   SYNCED   EXTERNAL-NAME           AGE
mssqlserver.sql.azure.upbound.io/op-2783f8w1-dns-alias   True    True     op-2783f8w1-dns-alias   6m23s

@turkenh
Copy link
Contributor Author

turkenh commented Oct 18, 2022

/test-examples="examples/sql/mssqlserverdnsalias.yaml"

@Upbound-CLA
Copy link

Upbound-CLA commented Nov 23, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ulucinar is it something we want to revisit after the reсent underlying tf provider bump?

@turkenf
Copy link
Collaborator

turkenf commented Mar 14, 2023

Required status checks have been changed, could you please rebase this PR?

@turkenh
Copy link
Contributor Author

turkenh commented Mar 27, 2023

/test-examples="examples/sql/mssqlserverdnsalias.yaml"

@turkenh turkenh requested review from turkenf and removed request for muvaf March 27, 2023 19:23
@turkenh
Copy link
Contributor Author

turkenh commented May 5, 2023

Covered with #445

@turkenh turkenh closed this May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azure.sql: can't create MSSQLServerDNSAlias
5 participants