Fix EKS Pod Identity endless reconciles with ResourceInUseException #1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pintonunes
requested review from
ulucinar,
sergenyalcin,
turkenf and
mbbush
as code owners
Signed-off-by: Pedro Nunes <[email protected]>
Signed-off-by: Pedro Nunes <[email protected]>
Signed-off-by: Pedro Nunes <[email protected]>
pintonunes
force-pushed
the
fix/eks_assoc_id
branch
from
4d8e670 to
5eef70a
Compare
Open
1 task
|
Nice! Could this be a problem everywhere stubs are used? |
I think it will depend on the AWS API. This one we need an assocId and the clusterName. And the tfId is not used. |
Signed-off-by: Pedro Nunes <[email protected]>
Signed-off-by: Pedro Nunes <[email protected]>
|
/test-examples="examples/eks/v1beta1/podidentityassociation.yaml" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes the provider using the wrong association id when status is not updated with the right association id.
If the association id is the initial stub one, we use the external name as association id.
Fixes #1437
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested