Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Bump examples and monitoring group to v1alpha2 #34

Merged
merged 2 commits into from
Jan 7, 2022

Conversation

turkenh
Copy link
Collaborator

@turkenh turkenh commented Jan 7, 2022

Description of your changes

APIs updated but examples not. This PR updates examples to correct versions.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Tested with bucket.

Signed-off-by: Hasan Turken <[email protected]>
@turkenh turkenh requested review from muvaf and ulucinar January 7, 2022 19:58
Copy link
Collaborator

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You may want to validate them using kubectl apply to have the validations run.

@turkenh
Copy link
Collaborator Author

turkenh commented Jan 7, 2022

LGTM. You may want to validate them using kubectl apply to have the validations run.

Good call, found out that monitoring group is not bumped to v1alphav2. Just pushed another commit.

@turkenh turkenh changed the title Bump examples to v1alpha2 Bump examples and monitoring group to v1alpha2 Jan 7, 2022
@turkenh turkenh merged commit 20609b2 into crossplane-contrib:main Jan 7, 2022
@turkenh turkenh deleted the bump-examples branch January 7, 2022 20:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants