This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Workaround for bucket bug: add timeout annotation #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hasan Turken <[email protected]>
turkenh
force-pushed
the
bucket-timeout-annotation
branch
from
f43064d to
bfe7b37
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR is a workaround for #12 which has the same underlying problem as this issue that is introduced to Terraform provider starting with version 3.89.0. The change causing the problem is this one adding retry's to read, create and update methods of bucket resource. In case of a non existing bucket, e.g. a terraform provisioned bucket removed from cloud console, plan/refresh call simply stuck for 20mins before returning that bucket does not exist.
In case of Terrajet, this is a bit more severe, since it is trying to refresh the resource in the first observe call resulting the behavior described in #12.
This PR introduces a metadata argument to the bucket example which configures it to timeout after 1 mins. This is still a temporary solution and we will followup with another Terraform fix and also consider best way deal with this type of issues in Terrajet.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Create/delete a bucket with the updated example.