This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Finalize config for API group/kind calculation #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turkenh
force-pushed
the
finalize-kinds-and-groups
branch
from
a037367 to
39c2f44
Compare
turkenh
changed the title
turkenh
changed the title
turkenh
changed the title
turkenh
force-pushed
the
finalize-kinds-and-groups
branch
from
838517f to
88f6dad
Compare
turkenh
force-pushed
the
finalize-kinds-and-groups
branch
from
88f6dad to
e31890f
Compare
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
turkenh
force-pushed
the
finalize-kinds-and-groups
branch
from
e31890f to
161001f
Compare
muvaf
reviewed
Jan 3, 2022
config/identityplatform/config.go
Outdated
| p.AddResourceConfigurator("google_identity_platform_oauth_idp_config", func(r *config.Resource) { | ||
| r.Kind = "OAuthIdPConfig" | ||
| }) | ||
| p.AddResourceConfigurator("google_identity_platform_tenant_default_supported_idp_config", func(r *config.Resource) { |
There was a problem hiding this comment.
I think we can add idp as IdP in acronym list if that's how it appears. FWIW, we can call AddAcronym in this repo as well since the list is global.
There was a problem hiding this comment.
Thanks, added them (IdP and OAuth) as GCP specific acronyms for now. We can consider migration them to terrajet later.
@muvaf done! |
Merged
2 tasks
Signed-off-by: Hasan Turken <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR updates configuration for all resources to finalize group/kind calculation.
I have:
make reviewable testto ensure this PR is ready for review.Click to see final resource grouping
How has this code been tested
N/A