Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epoch: Fix false sharing in Local struct #1026

Merged
merged 1 commit into from
Sep 12, 2023
Merged

epoch: Fix false sharing in Local struct #1026

merged 1 commit into from
Sep 12, 2023

Conversation

linericyang
Copy link
Contributor

The perf c2c data shows lots of cacheline contention were caused by false sharing between epoch and other field in "Local" struct. So use CachePadded class to align it to another cacheline to resolve this issue.

Fixes #1020

The perf c2c data shows lots of cacheline contention were caused by
false sharing between epoch and other field in "Local" struct. So
use CachePadded class to align it to another cacheline to resolve
this issue.
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e merged commit 4bb27db into crossbeam-rs:master Sep 12, 2023
25 checks passed
@linericyang linericyang deleted the false_sharing branch September 12, 2023 17:34
powergee pushed a commit to powergee/crossbeam that referenced this pull request Oct 18, 2023
The perf c2c data shows lots of cacheline contention were caused by
false sharing between epoch and other field in "Local" struct. So
use CachePadded class to align it to another cacheline to resolve
this issue.
taiki-e pushed a commit that referenced this pull request Dec 13, 2023
The perf c2c data shows lots of cacheline contention were caused by
false sharing between epoch and other field in "Local" struct. So
use CachePadded class to align it to another cacheline to resolve
this issue.
taiki-e pushed a commit that referenced this pull request Dec 13, 2023
The perf c2c data shows lots of cacheline contention were caused by
false sharing between epoch and other field in "Local" struct. So
use CachePadded class to align it to another cacheline to resolve
this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[crossbeam-epoch] false sharing issue for "epoch: AtomicEpoch" field in "Local" struct
2 participants