Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license file to include contributors #1628

Merged

Conversation

muzzammilshahid
Copy link
Contributor

@muzzammilshahid muzzammilshahid commented Jan 24, 2024

@oberstet
Copy link
Contributor

the fails https://github.com/crossbario/autobahn-python/actions/runs/7643742575/job/20829707541?pr=1628#step:8:70 are definitely unrelated .. I haven't analyzed the root cause .. likely some dependency changed its behavior making the previously working test here now fail:( oh well. yes, why don't we fix and pin all dependencies including CI here .. I spent countless hours of laying the ground for that, and actually do it, but I would not bet my life, well obviously I did not, address "all of it". tbh, I am also feeling that it might be a never ending, maybe unsolvable thing, at least very hard - in Python that is. anyways, that's just how I feel. your change is certainly welcome!

@yan12125
Copy link
Contributor

yan12125 commented Mar 1, 2024

Test failures are related to newer pytest-asyncio. If I use pytest-asyncio<0.22, all tests are still green. I'm not sure if it's an issue in newer pytest-asyncio like this, or something in autobahn needs changes.

@oberstet
Copy link
Contributor

oberstet commented Mar 2, 2024

@yan12125 thanks a lot for tracking this down! I had a peek, and it might be spot on. the breaking change

https://github.com/pytest-dev/pytest-asyncio/releases/tag/v0.23.0

relates to event_loop_policy, which needs to be adjusted similar to

https://github.com/pytest-dev/pytest-asyncio/pull/662/files

@om26er
Copy link
Contributor

om26er commented Mar 4, 2024

@Mahad-10, can you look into the CI failures and create a PR for that?

@yan12125
Copy link
Contributor

yan12125 commented Mar 4, 2024

@Mahad-10, can you look into the CI failures and create a PR for that?

FWIW, my WIP patches may be useful: master...yan12125:autobahn-python:pytest-async-0.23

@oberstet
Copy link
Contributor

I hate it. where did GH move the "rerun tests" button?

grafik


anyways. a merge commit of this PR should now actually run green. hope so.

@oberstet oberstet merged commit 75f3758 into crossbario:master Apr 13, 2024
5 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants