New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please help to improve cpython performance in xormask #1494

Closed

rwayan opened this issue Jul 14, 2021 · 1 comment

rwayan commented Jul 14, 2021 •

edited

Loading

Sorry for my poor english

python-websockets/websockets#466 (comment)

would you please patch this for cpython users ?

    from websockets.speedups import apply_mask
    class XorMaskerShifted1(object):

        __slots__ = ('_ptr', '_mskarray','_mask')

        def __init__(self, mask):
            assert len(mask) == 4
            self._mask = mask

        def process(self, data):
            return apply_mask(data,self._mask)

The text was updated successfully, but these errors were encountered:

rwayan changed the title ~~Please help to import cpython performance in xormask~~ Please help to improve cpython performance in xormask

Contributor

oberstet commented Jul 22, 2021

no, won't merge;

I guess it's native code and only in "websockets"
I care more about PyPy
we use wsaccel on cpy, but the actual solution would be to finish work on https://github.com/crossbario/autobahn-python/tree/master/autobahn/nvx

oberstet closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment