Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NaCl SealedBox #431

Closed
oberstet opened this issue Mar 9, 2019 · 4 comments
Closed

Support NaCl SealedBox #431

oberstet opened this issue Mar 9, 2019 · 4 comments

Comments

@oberstet
Copy link
Contributor

oberstet commented Mar 9, 2019

This issue is about the first step of supporting WAMP-cryptosign and XBR in AutobahnJava, which is integrate a NaCl library to that we can implement the former.

Ultimately, we want an ABJ equivalent of the code here:


I've looked at some of the libraries from here https://download.libsodium.org/doc/bindings_for_other_languages/, and spent a bit more time looking into lazysodium, which I had a good impression:

The other library that I looked at:


In WAMP-cryptosign and XBR we need:

  • nacl.signing.SigningKey
  • nacl.secret.SecretBox
  • nacl.public.SealedBox

and while I've seen SecretBox support in lazysodium and cava, not sure about SealedBox .. haven't seen that one.

In which case we would need to work with upstream to get support for that into the lib ..

@om26er what do you think? I think you once looked into NaCl libraries also / already .. not sure?

@om26er
Copy link
Contributor

om26er commented Mar 9, 2019

@om26er what do you think? I think you once looked into NaCl libraries also / already .. not sure?

yes, we do support Cryptosign in autobahn-java today, using https://github.com/joshjdevl/libsodium-jni, I just peaked into its source and it seems it doesn't implement SealedBox as well.

Regarding lazysodium, it seems fine, though is maintained by a single person, so wonder what happens if the person loses interest.

Here is our CryptosignAuth impl: https://github.com/crossbario/autobahn-java/blob/master/autobahn/src/main/java/io/crossbar/autobahn/wamp/auth/CryptosignAuth.java#L18

@oberstet oberstet changed the title Integrate a NaCl library Support NaCl SealedBox Mar 9, 2019
@oberstet
Copy link
Contributor Author

oberstet commented Mar 9, 2019

ahhh, right .. I forgot! cool=) so we have a NaCl library already integrated, and we only need to find out how to use SealedBox - or how work with upstream of https://github.com/joshjdevl/libsodium-jni to support it.

@om26er
Copy link
Contributor

om26er commented Mar 22, 2019

FYI, the upstream proposal lives here joshjdevl/libsodium-jni#127

@om26er om26er self-assigned this Mar 22, 2019
@om26er
Copy link
Contributor

om26er commented Apr 12, 2019

Closing this, we do have SealedBox in now. Also have some of the XBR stuff as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants