Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images with cargo and rustc built-in? #468

Closed
avkonst opened this issue Oct 12, 2020 · 1 comment · Fixed by #878
Closed

Images with cargo and rustc built-in? #468

avkonst opened this issue Oct 12, 2020 · 1 comment · Fixed by #878

Comments

@avkonst
Copy link

avkonst commented Oct 12, 2020

Great docker images are provided. When used with cross tool it works great. However, cross can not be invoked in any of the CI systems running builds inside a container. I have found what inheriting the images from "rust" base image instead or ubuntu/debian addresses the issue and the images can be used with cross and in CI too.

Is it possible to modify the images so they are inherited from "rust" image, or alternatively, where rustup/cargo/rustc are installed as a last step? If you would like to keep the current images smallish, is it possible to provide an additional set of the same images where rustup/cargo are installed too?

If these images were provided, I believe rust developers would consolidate and use these, instead of working around the issue creating private not-well-maintained derivatives from your images.

I am keen to submit pull request if you are ok with any of the above options.

Makes sense?

@Alexhuszagh
Copy link
Contributor

Alexhuszagh commented May 28, 2022

Isn't this superseded by the addition of the CROSS_DOCKER_IN_DOCKER environment variable, which was added in f2c70b3. With it, cross works fine inside a container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants