-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prefix tags in android images with ndk, sdk and os #1155
Comments
I do think it's worth it to keep a simple |
Would we then do multiple deployments, or a single deployment? If so, I think we only would need 1 NDK version (the latest, or |
Hi, I am running into the same issues specified in #1195. Right now I wanted to fix it by passing Maybe something like this: [target.armv7-linux-androideabi]
image = "ghcr.io/cross-rs/armv7-linux-androideabi:main"
build-args = ["ANDROID_NDK=r24", "ANDROID_SDK=21", "ANDROID_VERSION=5.0.0_r1"]
|
I dont think we should have multiple ndks in an image, that would be a huge image and take an imense amount of CI time in one step. What we could do is allow something similar where if you dont provide an explicit image, cross recognizes the env var |
Checklist
Describe your request
We should consider if we should rename the android images to
*-linux-androideabi:ndkxxy-sdkxx-osxx-<branch>
Describe why this would be a good inclusion for
cross
This would mean less confusion about what is included, and make it easier to maintain multiple versions without much effort (as
build-docker-image
could inject it for you`The text was updated successfully, but these errors were encountered: