Add repo tool to images #42
Conversation
The google repo tool helps manage projects with multiple git repos. Some use it for yocto. Closes: crops#22 Signed-off-by: Cormier, Jonathan <[email protected]> Used by AGL and multiple teams internally. Signed-off-by: Tim Orling <[email protected]>
|
I'll rebase if you merge git-lfs first. |
There was a problem hiding this comment.
I added some comments/feedback.
But, I'm still uncertain of adding this to the image, because none of the core metadata ever uses repo.(has that changed?) If repo is needed to fetch the source, and repo isn't desired on the host, could another image instead be used for the fetching?
I ask because there has to be "some" guidance for what helpful tools should be added into the container.
|
|
||
| # repo-test | ||
| # | ||
| # Copyright (C) 2016 Intel Corporation |
There was a problem hiding this comment.
Year should probably be updated.
| @@ -56,6 +56,9 @@ RUN yum -y install epel-release && \ | |||
| mkdir /etc/vncskel/.vnc && \ | |||
| echo "" | vncpasswd -f > /etc/vncskel/.vnc/passwd && \ | |||
| chmod 0600 /etc/vncskel/.vnc/passwd && \ | |||
| # Repo is a useful tool for checking out multiple git repos | |||
| wget https://storage.googleapis.com/git-repo-downloads/repo -O /usr/local/bin/repo && \ | |||
There was a problem hiding this comment.
Since this isn't coming from the package manager and thus doesn't do verification automatically, it should at least do a checksum comparison against an expected version.
There was a problem hiding this comment.
@rewitt1 @moto-timo: repo is a tool I want to be able to use in crops containers so taking a look at this. The issue is that the URL https://storage.googleapis.com/git-repo-downloads/repo gets you the latest release of repo and so we can't expect it to match any given checksum for long. repo really doesn't support running anything other than the very latest commit, it actually pulls the latest commit from its own git repository when you run it. Sadly it's a widely used tool and we do need to try to support it.
The https cert for storage.goolgeapis.com will be checked as part of this download so that should be safe.
There was a problem hiding this comment.
The source of most of this PR was from #22 including the Intel copyright (I don't think I did much modification of any of his work). I think #22 was just copy paste of existing scripts. We are currently installing repotool into the running container, so I have more or less stopped working on this. It is a frequent enough request to warrant further work. It would be great if you can pick this up @pbrkr
|
|
||
| # Pass in the image that was built for docker | ||
| image=$1 | ||
| workdir=`mktemp -d --suffix=vnc` |
There was a problem hiding this comment.
"vnc" looks like a copy-paste leftover.
|
@moto-timo: Any chance of getting this updated so it can be merged? If you're busy I can take over and make any necessary edits. |
|
Internally we went a different route to add "repo" and "git-lfs" via a derivative container model (which is in the process of being open sourced). We (and especially Randy, as the voice of MAINTAINER) have concerns about adding tools that are not generally usable to all. Containers are small, specialized and ephemeral. Derivative containers are viable. You should actually trust containers that YOU are building. |
The google repo tool helps manage projects with multiple git repos.
Some use it for yocto.
Closes: #22
Signed-off-by: Cormier, Jonathan [email protected]
Used by AGL and multiple teams internally.
Signed-off-by: Tim Orling [email protected]