Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to override the token used to push the changes #55

Closed
hpedrorodrigues opened this issue Jun 16, 2021 · 1 comment · Fixed by #56
Closed

Add support to override the token used to push the changes #55

hpedrorodrigues opened this issue Jun 16, 2021 · 1 comment · Fixed by #56
Labels
enhancement New feature or request

Comments

@hpedrorodrigues
Copy link
Contributor

hpedrorodrigues commented Jun 16, 2021

First of all, thanks for this project. 🚀

Problem
I'm using this action in a specific project for every Pull Request, but after it pushes the changes back to the PR, I expect this push to trigger another action. However, this seems to not work.

Why
This occurs because pushes using the default environment variable GITHUB_TOKEN don't trigger a new workflow, even when configured. So as pointed in this discussion a possible solution is to create a personal token.

What I've tried
Following this idea, I've created a personal token, but as this action has no option to override the token yet, I tried to override the default env var GITHUB_TOKEN.

env:
  GITHUB_TOKEN: ${{ secrets.PERSONAL_GITHUB_TOKEN }}

However, as the docs says, if we attempt to override the value of one of the default environment variables, the assignment is ignored.

What would you like to change about the program?
I'd like to have an option to override the token used to push the changes.
It could be a new environment variable or a new parameter to the action.

Why do you think this is a cool idea?
With this change, we'll be able to trigger another workflow after the fixes have been pushed.

Idk if I'm missing something here, so please let me know.

If you think this feature makes sense, I can start working on the PR.

@hpedrorodrigues hpedrorodrigues added the enhancement New feature or request label Jun 16, 2021
@hpedrorodrigues hpedrorodrigues changed the title Add support to use override the token used to push the changes Add support to override the token used to push the changes Jun 16, 2021
@creyD
Copy link
Owner

creyD commented Jun 16, 2021

Will be available in the next version.

@creyD creyD closed this as completed Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants