Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] 404 page style broken #208

Closed
log901108 opened this issue Nov 30, 2019 · 3 comments
Closed

[Bug] 404 page style broken #208

log901108 opened this issue Nov 30, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@log901108
Copy link

Version

1.8.0

Reproduction link

https://demos.creative-tim.com/material-dashboard-pro-react/#/auth/error-page

Operating System

ubuntu 18.4

Device

mobile

Browser & Version

any

Steps to reproduce

  1. move to link or get in 404 error page
  2. make the browser window size smaller or browsing sites with mobile or tablet pc.
  3. 404 error page style is broken. It seems have problem with relative things.

What is expected?

the error-page should resize in display size.

What is actually happening?

the error-page shows broken style without resizing


Solution

Additional comments

@einazare
Copy link
Contributor

einazare commented Dec 2, 2019

Hello there, @log901108 ,

Thank you for your interest in working with our products, and for using our issue template.
To solve the issue please go inside src/assets/jss/material-dashboard-pro-react/layouts/authStyle.js file, and delete the following lines of code:

    [theme.breakpoints.down("sm")]: {
      minHeight: "fit-content!important"
    },

Let me know if this helped.

Best,
Manu

@einazare einazare added the bug Something isn't working label Dec 2, 2019
@log901108
Copy link
Author

It still happened at some mobile browser (specifically samsung mobile webbrowser). Footer section intrudes contents section. I think the problem is happened because the footer can intrude not-react-components like 'h1','h2'... of plain html tag

@einazare
Copy link
Contributor

einazare commented Dec 4, 2019

Hello again, @log901108 ,

I've realised that you can change the following code:

    [theme.breakpoints.down("sm")]: {
      minHeight: "fit-content!important"
    },

To

    [theme.breakpoints.down("sm")]: {
      minHeight: "700px!important"
    },

This will make sure that even on small screens everything will stay properly.

Best,
Manu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants