Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] List pages only display languages matching legal code languages #265

Open
TimidRobot opened this issue Mar 4, 2022 · 5 comments
Open

[Bug] List pages only display languages matching legal code languages #265

TimidRobot opened this issue Mar 4, 2022 · 5 comments
Assignees
@TimidRobot
Labels
💻 aspect: code Concerns the software code in the repository 🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work

Comments

@TimidRobot
Copy link
Member

TimidRobot commented Mar 4, 2022 •
edited
Loading

Description

List pages only display languages matching legal code languages

Reproduction

  1. Visit a list page
    • /licenses/list
    • /publicdomain/list

Expectation

Options

  1. list pages should show all deed languages for most recent version of each non-retired legal tool (previous versions and retired legal tools should only show deed languages for languages matching legal code languages)
    • 165 current language rows on Licenses List page
    • this option is a compromise between completeness and length
  2. list pages (with a single page for licenses) should show all deed languages for all versions of a legal tool
    • 4,431 expected language rows on Licenses List page
    • this option would be a terrible user experience
  3. list pages (with separate pages for each version of the licenses) should show all deed languages for all versions of a legal tool
    • 1,860 expected language rows on 3.0 Licenses List page
    • this option would be a terrible user experience
  4. list pages should only show deed languages for languages matching legal code languages (how things are currently, no change)
    • 151 current language rows on Licenses List page
  5. list pages should show only each unique legal tool using the selected language
    • 104 rows on Licenses List page
    • (this option would also allow more variance in how the legal tools are presented)

Screenshots

🖼️ Screenshot (truncated)

Screenshot 2022-03-04 at 14-45-43 Licenses List

Additional context
@TimidRobot TimidRobot added 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Mar 4, 2022
@TimidRobot TimidRobot self-assigned this Mar 4, 2022
@TimidRobot
Copy link
Member Author

TimidRobot commented Mar 4, 2022 •
edited
Loading

I think options 2 & 3 are untenable.

Between options 1 & 4, I like option 1.

@TimidRobot TimidRobot mentioned this issue Mar 4, 2022
Closed
@annatuma
Copy link

annatuma commented Mar 4, 2022

Agreed. Option 1 is the best balance of accuracy and usability.

@TimidRobot
Copy link
Member Author

TimidRobot commented Mar 16, 2022 •
edited
Loading

Also, the jurisdictions are sorted by code, so they appear out of order (ex. es is Spain). Consider displaying jurisdiction or sorting for each language.

@Tapo41

This comment was marked as outdated.

Sign in to view
@TimidRobot
Copy link
Member Author

Having given this more thought, I've added option 5, which is my new preference.

@TimidRobot TimidRobot added 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work 🕹 aspect: interface Concerns end-users' experience with the software and removed 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Mar 4, 2024
@TimidRobot TimidRobot added the help wanted Open to participation from the community label Mar 5, 2024
@TimidRobot TimidRobot moved this to Backlog in TimidRobot Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TimidRobot TimidRobot

Labels
💻 aspect: code Concerns the software code in the repository 🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work
Projects
TimidRobot
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TimidRobot @annatuma @Tapo41