From 3abf458f02ea9f96d9c45f7e735aea501ae65ef8 Mon Sep 17 00:00:00 2001 From: Vitaly Potyarkin Date: Fri, 28 Apr 2023 11:26:34 +0000 Subject: [PATCH] Notify about intentionally using blocking io on Darwin --- io_test.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/io_test.go b/io_test.go index 5884665..0837d9e 100644 --- a/io_test.go +++ b/io_test.go @@ -72,6 +72,13 @@ func TestReadClose(t *testing.T) { // Open pty and setup watchdogs for graceful and not so graceful failure modes func prepare(t *testing.T) (ptmx *os.File, done func()) { + if runtime.GOOS == "darwin" { + t.Log("creack/pty uses blocking i/o on darwin intentionally:") + t.Log("> https://github.com/creack/pty/issues/52") + t.Log("> https://github.com/creack/pty/pull/53") + t.Log("> https://github.com/golang/go/issues/22099") + t.SkipNow() + } // Due to data race potential in (*os.File).Fd() // we should never run these two tests in parallel