Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): add AddDevices function #89

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

BlackHole1
Copy link
Contributor

In most cases, there might be more than one device. Adding the AddDevices method helps reduce the amount of code.

In most cases, there might be more than one device. Adding the AddDevices method helps reduce the amount of code.

Signed-off-by: Kevin Cui <[email protected]>
Copy link

openshift-ci bot commented Jan 25, 2024

Hi @BlackHole1. Thanks for your PR.

I'm waiting for a crc-org member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cfergeau
Copy link
Collaborator

/ok-to-test
/lgtm
/approve
/hold

(holding so that the tests run before we merge it)

Copy link

openshift-ci bot commented Jan 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cfergeau
Copy link
Collaborator

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit 979f84f into crc-org:main Jan 25, 2024
5 checks passed
@BlackHole1 BlackHole1 deleted the add-AddDevices branch January 25, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants