rosetta: add option to ignore rosetta failure when installation cancelled #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lstocchi
force-pushed
the
i160
branch
2 times, most recently
from
39cc8c3 to
92a0169
Compare
cfergeau
reviewed
Oct 7, 2024
There was a problem hiding this comment.
Haven't tested this extensively, but looks good to me.
It would be nice to update the documentation as well to mention the new option, and to add a Fixes https://github.com/crc-org/vfkit/issues/160 in the commit log so that the corresponding issue is automatically fixed.
|
Forgot to update the documentation, updating it |
cfergeau
reviewed
Oct 11, 2024
added 2 commits
October 11, 2024 18:15
…lled
this adds a ignore-if-missing option that allows vfkit to not fail if the rosetta installation do not succeed for some reason (e.g. user cancelled installation).
So far, if the rosetta installation was cancelled or failed vfkit exited with an error. This behavior still exists if ignore-if-missing option is not set or it is false.
This will be used by podman bc there could be a fallback and rosetta could also be not mandatory containers/podman#23153
it fixes crc-org#160
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a ignore-if-missing option that allows vfkit to not fail if the rosetta installation is cancelled by the user.
So far, if the rosetta installation was cancelled vfkit exited with an error. This behavior still exists if ignore-if-missing option is not set.
it fixes #160