Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move linting to separate job. #156

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

williamtheaker
Copy link
Contributor

Currently, each job in the matrix strategy runs golangci-lint, which is slightly inefficient and expensive given the price of macOS runners. This PR moves the lint step to a separate job and defaults to the stable version of Go.

Copy link

openshift-ci bot commented Jun 14, 2024

Hi @williamtheaker. Thanks for your PR.

I'm waiting for a crc-org member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

.github/workflows/compile.yml Outdated Show resolved Hide resolved
@williamtheaker williamtheaker requested a review from cfergeau July 8, 2024 15:37
@cfergeau
Copy link
Collaborator

cfergeau commented Jul 9, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 9, 2024
@cfergeau
Copy link
Collaborator

cfergeau commented Jul 9, 2024

/approve

Copy link

openshift-ci bot commented Jul 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 9, 2024
@cfergeau cfergeau merged commit 966a928 into crc-org:main Jul 10, 2024
4 of 6 checks passed
@williamtheaker williamtheaker deleted the wt.lint_ci branch October 8, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants