Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use paths that require URI escaping after interpolation #79

Open
croddy opened this issue Apr 1, 2019 · 0 comments
Open

Cannot use paths that require URI escaping after interpolation #79

croddy opened this issue Apr 1, 2019 · 0 comments

Comments

@croddy
Copy link

croddy commented Apr 1, 2019

When the values from interpolated variables require escaping in order to be assembled into valid URIs, it is impossible to use them.

This is due to HI-612: within Hiera itself, the URI must already be valid immediately after variable interpolation, or the lookup will fail long before reaching hiera-http code. I also cannot pre-escape the URI, because hiera-http will later escape it a second time.

I think that the right solution is for Hiera itself to perform URI escaping as I proposed on HI-612, and for hiera-http to remove the escaping that currently happens in http_get.

Currently, the best workaround we have found is to individually pre-escape and reassign variables used for hiera-http paths and to use those instead. However, this also required us to fork hiera-http and remove the escaping in http_get in order to prevent them from being doubly escaped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant