Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utility function for properly quoting table names, full-qualified or not #69

Closed
amotl opened this issue Jun 13, 2024 · 2 comments
Closed

Comments

@amotl
Copy link
Member

amotl commented Jun 13, 2024

About

@seut improved the table name quoting function in CrateDB Toolkit.

My thoughts are whether this could also be useful for users of the CrateDB SQLAlchemy dialect in one way or another, mostly on utility use cases like introspecting / reflecting table information using SQLAlchemy's inspector.

It does not need to happen today or tomorrow, because Toolkit is exactly also for incubating purposes, but it may happen to migrate this method on behalf of a future iteration. wdyt?

@seut
Copy link
Member

seut commented Jun 14, 2024

My thoughts are whether this could also be useful for users of the CrateDB SQLAlchemy dialect in one way or another, mostly on utility use cases like introspecting / reflecting table information using SQLAlchemy's inspector.

I don't think that this utility function can go into the SQLAlchemy dialect as this helper will also work with full-qualified names while this is not expected to do this inside SQLAlchemy. The quote method a dialect can override is only intended to be used with non-full-qualified identifiers, but not with fqn ones which e.g. contain a schema.

@amotl
Copy link
Member Author

amotl commented Jun 14, 2024

All right. Maybe it was a Schnapsidee. Let's close this issue again, thanks for your response.

@amotl amotl closed this as not planned Won't fix, can't repro, duplicate, stale Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants