Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload Python package to PyPI #3

Closed
surister opened this issue Apr 15, 2024 · 7 comments
Closed

Upload Python package to PyPI #3

surister opened this issue Apr 15, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@surister
Copy link
Collaborator

surister commented Apr 15, 2024

The Python variant of the package needs to be uploaded to PyPI.

@surister surister added the enhancement New feature or request label Apr 15, 2024
@amotl
Copy link
Member

amotl commented Apr 15, 2024

We are running a few projects with valid and mature pyproject.toml configurations to ease uploading to PyPI. Let us know if we should contribute a corresponding piece here, to save you a few keystrokes.

@surister
Copy link
Collaborator Author

We are running a few projects with valid and mature pyproject.toml configurations to ease uploading to PyPI. Let us know if we should contribute a corresponding piece here, to save you a few keystrokes.

Sure thing!

@amotl
Copy link
Member

amotl commented Apr 25, 2024

Hi. I just wanted to have a look at packaging, but then, I discovered in this documentation section, that the parser would actually not be part of the package by default, so it would not be usable right away for people having different expectations?

Let's look into this on behalf of an out-of-band sync, and report back later here about the outcome?

@surister
Copy link
Collaborator Author

Not part of the repo, we have to create the parser at packaging time so the packages are usable

@amotl
Copy link
Member

amotl commented May 17, 2024

Hi again. That patch brings a few things into place, also CI concerns, in order to prepare packaging and publishing.

@amotl
Copy link
Member

amotl commented May 21, 2024

Because the JavaScript package was already at version 0.0.2, the repository has now been tagged with v0.0.2.
Based on that, and the previous improvements, the Python package has been published to PyPI now.

-- https://pypi.org/project/cratedb-sqlparse/

@amotl amotl changed the title Upload python package to pip Upload Python package to PyPI May 21, 2024
@surister
Copy link
Collaborator Author

Amazing, thanks for the help.

We should also document somewhere (maybe in the README) the relation between the cratedb-sqlparse version and the CrateDB version itself, also I would add a small note on the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants