You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be nice to load config by default from .config/committed.toml, in addition to a top level committed.toml and the path configurable with the command line option.
There are some initiatives for this that document the full rationale for this so I won't repeat that here, for example
This is not widely used practice yet, but IMO makes great sense. The pi0/config-dir of the above seems to be the most active of the initiatives at the moment, and documents the motivation as well as why the command line option to set a custom config is not in general a proper replacement for this.
As far as committed goes, the number of different environments from which it is launched under a normal workflows is not that big, so using --config .config/committed.toml is more scalable than with other kinds of tools
git commit-msg hooks
CI pipelines for checking PR branches
However, that still needs to be duplicated in two places, and for example if one wants that when using the committed GH action, one needs to duplicate the action's default args, can't just append --config there.
If accepted, I can have a look at implementing this.
The text was updated successfully, but these errors were encountered:
It would be nice to load config by default from
.config/committed.toml
, in addition to a top levelcommitted.toml
and the path configurable with the command line option.There are some initiatives for this that document the full rationale for this so I won't repeat that here, for example
This is not widely used practice yet, but IMO makes great sense. The pi0/config-dir of the above seems to be the most active of the initiatives at the moment, and documents the motivation as well as why the command line option to set a custom config is not in general a proper replacement for this.
As far as committed goes, the number of different environments from which it is launched under a normal workflows is not that big, so using
--config .config/committed.toml
is more scalable than with other kinds of toolsHowever, that still needs to be duplicated in two places, and for example if one wants that when using the committed GH action, one needs to duplicate the action's default args, can't just append --config there.
If accepted, I can have a look at implementing this.
The text was updated successfully, but these errors were encountered: