Package commit message setting is ignored when another crate is added to the workspace

[bluurryy]

When a second crate is added to the workspace, the package setting for commit messages is ignored and the workspace setting is used instead.

I would expect cargo-release to change its behavior only when I use --workspace, not automatically.

This means that currently, when a user adds a second crate to their workspace, they will suddenly no longer get their custom commit message. There is no warning, error, or prompt about this setting being ignored.

This is related to:

• wrong commit message when cargo release --workspace is run with single crate #701

See this issue for the root cause and expected fixes.

[epage]

Could you explain how this is different than #701 that a separate issue is opened?

[epage]

Ok, I looked closer at #701 and it is related to consolidated-commits but slightly different.

cargo-release prioritizes consistency in behavior to make it more predictable. In this case, that means if under one situation, a commit message is used, then its used under all.

You can disable this behavior with consolidate-commits = false.

[bluurryy]

Could you explain how this is different than #701 that a separate issue is opened?

I was thinking this is a different issue that might have the same root cause but I'm not sure if a fix to #701 would also fix this issue.

[bluurryy]

You can disable this behavior with consolidate-commits = false.

That prints:

warning: ignoring `consolidate-commits=false`; `cargo release commit` can effectively only do one commit

And the commit message becomes literally:

chore: Release {{crate_name}} version {{version}}

I have created a repo where I'm testing this behavior: https://github.com/bluurryy/cargo-release-commit-message-issue

[bluurryy]

Oh hold on I have just been testing this with just cargo release version and cargo release commit. Is that wrong?

[epage]

#680 is about cargo release commit not supporting consolidated-commits = false. If you test with cargo release (which does a dry-run by default), you should see it being used.

[bluurryy]

#680 is about cargo release commit not supporting consolidated-commits = false. If you test with cargo release (which does a dry-run by default), you should see it being used.

Yes that worked! Thank you for the help!

I can see now how the current behavior makes sense.

I suppose it would help if there was a warning whenever there is an unused package setting. I was very confused why the commit message setting suddenly didn't work anymore 😅 .