Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle analysing messages with no headers. #1017

Merged
merged 1 commit into from
Jan 21, 2020
Merged

Handle analysing messages with no headers. #1017

merged 1 commit into from
Jan 21, 2020

Conversation

crankyoldgit
Copy link
Owner

  • Auto analysis failed if there was no header marks or spaces.
  • Adjust code to handle that situation.
  • Add unit test coverage for that situation.

For #1014

@crankyoldgit
Handle decoding messages with no headers.
1691893 
Auto analysis failed if there was no header marks or spaces. Adjust code 
to handle that situation.
* Add unit test coverage for that situation.

For #1014
@crankyoldgit crankyoldgit self-assigned this Jan 17, 2020
@crankyoldgit crankyoldgit changed the title Handle decoding messages with no headers. Handle analysing messages with no headers. Jan 17, 2020
@crankyoldgit
Copy link
Owner Author

Thanks @jamsinclair

@crankyoldgit crankyoldgit merged commit 6c5b08d into master Jan 21, 2020
@crankyoldgit crankyoldgit deleted the Issue1014 branch January 22, 2020 23:28
crankyoldgit added a commit that referenced this pull request Jan 30, 2020
@crankyoldgit
v2.7.3 release
f22400b 
_v2.7.3 (20200130)_

**[Features]**
- Allow protocols to be enabled or disabled with compiler flags. (#1013, #1012)
- Panasonic AC: Add Ion Filter support for DKE models. (#1025, #1024)
- Add support for sending Sony at 38Khz (#1029, #1018, #1019)
- auto_analyse_raw_data.py: Handle analysing messages with no headers. (#1017)

**[Misc]**
- Fix Coolix unit test errors when using Apple c++ compiler. (#1030, #1028)
- Fix Apple clang c++ compiler error in unit tests. (#1027, #1026)
- Improve/fix scraping of supported devices (#1022)
- Panasonic PKR series A/C uses DKE protocol. (#1020, #1021)
- Update NEC supported devices. (#1018)
- Add note to avoid GPIO16 on the ESP8266 for receiving. (#1016, #1015)
@crankyoldgit crankyoldgit mentioned this pull request Jan 30, 2020
Merged
crankyoldgit added a commit that referenced this pull request Jan 30, 2020
@crankyoldgit
v2.7.3 release (#1032)
0c6ba2d 
_v2.7.3 (20200130)_

**[Features]**
- Allow protocols to be enabled or disabled with compiler flags. (#1013, #1012)
- Panasonic AC: Add Ion Filter support for DKE models. (#1025, #1024)
- Add support for sending Sony at 38Khz (#1029, #1018, #1019)
- auto_analyse_raw_data.py: Handle analysing messages with no headers. (#1017)

**[Misc]**
- Fix Coolix unit test errors when using Apple c++ compiler. (#1030, #1028)
- Fix Apple clang c++ compiler error in unit tests. (#1027, #1026)
- Improve/fix scraping of supported devices (#1022)
- Panasonic PKR series A/C uses DKE protocol. (#1020, #1021)
- Update NEC supported devices. (#1018)
- Add note to avoid GPIO16 on the ESP8266 for receiving. (#1016, #1015)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamsinclair jamsinclair jamsinclair approved these changes

@sillyfrog sillyfrog Awaiting requested review from sillyfrog

@darshkpatel darshkpatel Awaiting requested review from darshkpatel

Assignees

@crankyoldgit crankyoldgit

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crankyoldgit @jamsinclair