Merge pull request #4 from tappleby/bugfix-payment-success

Response success logic

src/Receipt.php

@@ -39,6 +39,14 @@ public function __construct($data)
         ]);
     }
 
+    public function successful() {
+        $complete = $this->read('complete');
+        $valid_code = $this->read('code') !== 'null';
+        $code = (int)$this->read('code');
+
+        return $complete && $valid_code && $code >= 0 && $code < 50;
+    }
+
     /**
      * Read an item from the receipt.
      *

src/Response.php

@@ -140,12 +140,10 @@ public function validate()
             return $this;
         }
 
-        $code = (int)$receipt->read('code');
+        $this->successful = $receipt->successful();
 
-        if ($code >= 50 || $code === 0) {
+        if (!$this->successful) {
             $this->status = $this->convertReceiptCodeToStatus($receipt);
-            $this->successful = false;
-
             return $this;
         }
 
@@ -176,23 +174,19 @@ public function validate()
             }
 
             $this->failedAvs = true;
-            $this->successful = false;
 
             return $this;
         }
 
         $code = !is_null($receipt->read('cvd_result')) ? $receipt->read('cvd_result') : null;
 
-        if ($gateway->avs && !is_null($code) && $code !== 'null' && !in_array($code{1}, $gateway->cvdCodes)) {
+        if ($gateway->cvd && !is_null($code) && $code !== 'null' && !in_array($code{1}, $gateway->cvdCodes)) {
             $this->status = self::CVD;
             $this->failedCvd = true;
-            $this->successful = false;
 
             return $this;
         }
 
-        $this->successful = true;
-
         return $this;
     }