Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with tables for Commerce Variants #1168

Closed
CharlieGentle opened this issue Jul 12, 2022 · 5 comments
Closed

Issue with tables for Commerce Variants #1168

CharlieGentle opened this issue Jul 12, 2022 · 5 comments
Labels

Comments

@CharlieGentle
Copy link

Hi, I'm trying to add support for Feed Me to a custom field type in a plugin. It works ok when added to Entries and Products but when I move it to a Variant it stops working. In trying to debug this I think I've found it shares the same issue as Table field types do on Variants. The _parseVariants function fails to parse the table columns and doesn't get fields from $fieldInfo.

Steps to reproduce

  1. Create Commerce Product with variants
  2. Add table filed type to the variants
  3. Create feed and map data to the table field
  4. Run feed, variants will not be updated with the mapped data.

Additional info

  • Craft version: 4.1.0.2
  • PHP version: 8.0.20
  • Plugins & versions: Feed Me 5.0.4, Craft Commerce 4.0.4
@samuelbirch
Copy link

Any updates on this?

@CharlieGentle
Copy link
Author

Pull request submitted to fix this issue.

@robzor
Copy link

robzor commented Aug 24, 2022

+1 to this issue, it is a major issue with an upcoming critical data import

@angrybrad do you have any time to have a look at this?

@bymayo
Copy link

bymayo commented Nov 29, 2022

+1 also

Similar related issue posted 2 years ago with solution #464

@angrybrad
Copy link
Member

Resolved for the next v4 and v5 releases via #1268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants