Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] "pageTrigger" config setting causes unwanted CP redirects if its name matches the primary entry type of a section #4631

Closed
jsunsawyer opened this issue Jul 22, 2019 · 3 comments

Comments

@jsunsawyer
Copy link

jsunsawyer commented Jul 22, 2019

Description

We were having a problem where, after updating to 3.2, we could no longer create new entries for a specific section.

This section was generically titled Pages with a handle of page.

Our pageTrigger value was set to page/. Changing to anything other than page/ made entries work like normal again. Testing against another section's primary entry type, I was able to change the pageTrigger name to break those sections in a similar way.

Steps to reproduce

  1. Create a section with an entry type
  2. Set your pageTrigger config setting to match the name of that section's entry type, plus a trailing slash
  3. Try to create a new entry for your section

Additional info

  • Craft version: 3.5.1
@brandonkelly
Copy link
Member

I could see how this could be an issue if the section handle matches the pageTrigger config setting, as section handles are included as URL segments when editing entries. Not entry type handles though; did you just mistype that, but really mean sections?

I’m also not sure what the 3.2 update would have done to provoke this. You’re sure that the handle was page before updating to 3.2 and things worked fine before then?

@jsunsawyer
Copy link
Author

@brandonkelly Ah, you're right. Upon double checking, it seems that the issue is only occurring because of the section's handle. My pages section had the handle of page, and the other section I tested had the same handle faq as the entry type I was testing vs the pageTrigger, faq as well.

Yes, everything worked properly before the 3.2 update. Our guess was that it had something to do with structure type sections having pagination now, but unsure what that may be.

@brandonkelly
Copy link
Member

Fixed this for the next release. I was only able to reproduce if the pageTrigger ended in a trailing slash (e.g. page/), though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants