$this->isFresh($element) seems to not be working

[lewisjenkins]

Description

When checking $this->isFresh($element) in my plugins, it's suddenly never true, even for brand new entries.

For example:

public function getInputHtml($value, ElementInterface $element = null): string
{
    if ($this->isFresh($element) {
        // Never true, even on brand new entries.
    }
}

Steps to reproduce

The quickest way to test is with a standard Number field, which uses $this->isFresh($element) to check if the default value should be used.

1. Create a new number field
2. Give it a default value
3. Add it to a section
4. Create a new entry. The number field is empty.

Additional info

• Craft version: 3.2.3

[brandonkelly]

As of Craft 3.2, entries are now created in an ephemeral “unsaved draft” state up until the first time you click “Save Entry”. So by the time getInputHtml() is called, the entry will already exist on some level, so it’s expected that isFresh() would always return false. It will still return true when that unsaved draft is initially created though, if you were to call it from normalizeValue() for example.

[lewisjenkins]

Thanks for the explanation. What will happen with Craft's built-in Number Field, which has a Default Value setting that gets applied for new elements? If it's no longer working as documented then I guess it's a bug? Should I create a new issue?

[brandonkelly]

Ah, thanks for pointing that out, this issue is fine. I’ll fix…

[brandonkelly]

Fixed for the next release.