-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please add Preview option back in by default when editing an Entry!!! #4584
Comments
@rogerdawkins , I had some thinking on this when first announced, which might possibly be helpful, along with @brandonkelly 's explanation above it.. You can find the note here: #4535 (comment) . The gist is that making a draft be a Draft, as this update does, is actually safer, and closer to normal editorial practice, at least I feel. If you find agreement, this might help sell the idea in with your clients... |
@narration-sd Thanks for your input. I can understand what you are saying that in a full Editorial process there may be merits in creating a Draft first. But typically, IMHO, Craft CMS is used by companies wanting to simply edit content on their web pages. If you read any review of Craft CMS the one thing that every review will eulogise on is how wonderful Live Preview is (and how easy it is to use) and that content editors love it. This change has moved what is one of the 'Jewels in the Crown' of Craft CMS and hidden it behind an unintuitive UX. I appreciate it has all come about as part of changes to support a Headless Preview but I would prefer a system setting somewhere that allows Headless Preview and this new system is used for websites that require it and the old pre-3.2 system that uses Draft versions purely for Content Editor versions and Live Preview to always be available. |
I wasn’t excited about dropping it either. I’m thinking we might bring it back, and just have Craft create a draft over Ajax like we did in 3.2.0 - 3.2.2, but just not until the user actually clicks either “Preview” or “Save as a draft”. |
@brandonkelly I was thinking about it after adding this comment earlier and I came up with the same idea. Add the Preview button and then when it is clicked you can create a draft behind the scenes. I think that would be a great solution. |
If the preview is tied to the draft system, does this mean that auto-saving must be turned on to use it? That would be quite problematic as someone might play around in the editor on a draft unknowingly changing it. As we don't have auto-saving in the regular element editor this behavior would be difficult to grasp. Also, why is the live preview now so tightly bound to the draft system? We had a perfectly working preview in Craft 3.1 and the code for it ( |
@sebastian-lenz Yes, drafts still get auto-saved, and there’s no way to turn that off. Craft makes it clear that changes are getting saved via the autosave indicator though, so I don’t expect anyone will be surprised by it. There were a number of issues with the old Live Preview functionality. It was slower, required template hacks if you needed to set parameters on Matrix / relational field queries, and was generally pretty buggy. The new implementation solves all of that, in addition to making it possible to preview your entries in other contexts with Preview Targets, plus the new headless/decoupled preview capability. |
Just released Craft 3.2.4 which brings back the Preview button for Current entry revisions, which acts as a shortcut for clicking “Save as a Draft” + “Preview” 🎉 |
That was quick 😄 ... in and out, or out and in, I guess. @brandonkelly , I've given this a little time before responding, and maybe have a good combo plan.
Here's the extra benefit part.
Thanks, and the evident-others parts has me thinking amusing thoughts about positioning -- it will work 😊 |
Nothing has changed about new entries in either 3.2.3 or 3.2.4. They continue to be created as ephemeral “unsaved drafts”, and have autosave up until the “Save Entry” button is clicked.
Are you telling me that when you save an entry, the entry gets saved? |
Yeah, that's the problem. There's no Entry element which has the Draft. Thus: a) CraftQL can't see it, because it schemas drafts only as a property of entries. If it even did, then it would take an entirely different GraphQL query to find it -- thus not transparent for drafts as you know is such a nice feature allowing CraftQL to work transparently for previews. Thus this auto-save-on-preview does need to make an Entry. How that entry should be treated gets to the next point, yes...
Well, yes. I'm thinking this way to solve, maybe.
How do you like those apples, with your better insight? |
slight clarity update on solution |
a little more clarification as I go out the door for a time... |
@brandonkelly This morning's insight is that I believe to have a way to solve this. The kind you get from looking away. It comes out of that kit of object parts that built up in assembling the final Live Vue architecture which enables Gatsby and Gridsome in a way that ordinary folks can handle it, which you know has been operating 'a while', tracking Craft's moves. Thinking it out a present, and I'll put a note on Craft's support line. |
Description
I've just updated to 3.2.3 and would like to request that Preview is added back in as default when you first open an Entry to Edit it. The workflow when I'm editing and as far as I know all of my clients is to Edit an Entry and then the first thing they do is click Preview and then start editing. It is totally unintuitive to have to save a draft before you can do a Preview. Please change this beahaviour!!!!
Steps to reproduce
Additional info
The text was updated successfully, but these errors were encountered: