Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

craft command line tool should return non-0 on failure #4153

Closed
marionnewlevant opened this issue Apr 17, 2019 · 2 comments
Closed

craft command line tool should return non-0 on failure #4153

marionnewlevant opened this issue Apr 17, 2019 · 2 comments
Assignees

Comments

@marionnewlevant
Copy link

Description

The craft command line tool returns 0 even when it fails because e.g. the php version is less than 7.0

This is makes my automated deploy think it has succeeded when it hasn't.

@brandonkelly
Copy link
Member

Craft was already returning 0 or 1 for all console actions, but if PHP was under 7.0 that was the one exception. Fixed for the next release!

@marionnewlevant
Copy link
Author

console/controllers/ProjectConfigController.php returns ExitCode::OK even when:

Your project.yaml file was created for different versions of Craft and/or plugins than what’s currently installed. Try running composer install from your terminal to resolve.

or

Craft is not configured to use project.yaml. Please enable the 'useProjectConfigFile' config setting in config/general.php.

Which I don't think it should. (I want my automated deploy to fail for these sorts of things).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants