Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on Arabic language when entry has post date #3509

Closed
onemoreahmad opened this issue Nov 30, 2018 · 2 comments
Closed

Error on Arabic language when entry has post date #3509

onemoreahmad opened this issue Nov 30, 2018 · 2 comments

Comments

@onemoreahmad
Copy link

onemoreahmad commented Nov 30, 2018

Description

If the user changed his preference language to Arabic, he gets an error when he try to open any entry has a post date.

Steps to reproduce

  1. Publish any entry
  2. Change language to Arabic

Additional info

  • Craft version: Craft Pro 3.0.33
  • PHP version: 7.2.9

I think the error has to do with Arabic language file for the craft itself or maybe datepicker javascript library (?)
vendor/craftcms/cms/lib/datepicker-i18n/datepicker-ar.js
Have no idea.

screen shot 2018-11-30 at 5 17 13 pm

Entries have postDate NULL work fine, other don't

screen shot 2018-11-30 at 5 17 23 pm

screen shot 2018-11-30 at 5 17 56 pm

@brandonkelly
Copy link
Member

This should be fixed for the next release. I wasn’t able to reproduce your exact error (the page loaded fine, but I got a JavaScript error on it). So if you can test it yourself, I’d appreciate it.

You can get the fix by opening your composer.json file and changing your craftcms/cms requirement to dev-develop:

"require": {
  "craftcms/cms": "dev-develop as 3.0.33",
  "...": "..."
}

Then run composer update.

@onemoreahmad
Copy link
Author

Thank you @brandonkelly for the quick response , changing craft version and updating composer fixed the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants