Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x]: "tag" constructor argument of the "craft\web\twig\nodes\GetAttrNode" class is deprecated #16107

Closed
michtio opened this issue Nov 13, 2024 · 2 comments
Labels

Comments

@michtio
Copy link
Contributor

michtio commented Nov 13, 2024

What happened?

Description

Since the upgrade to Craft 5.5 our tracking systems get flooded with deprecation warnings from Twig, more specifically:

Since twig/twig 3.12: The "tag" constructor argument of the "craft\web\twig\nodes\GetAttrNode" class is deprecated and ignored (check which TokenParser class set it to "null"), the tag is now automatically set by the Parser when needed.

Expected behavior

It would be nice if this is adjusted, or the deprecation errors could be silenced.

Craft CMS version

5.5.0.1

PHP version

8.3.2

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

@michtio michtio added the bug label Nov 13, 2024
@i-just i-just changed the title [5.x]: [5.x]: "tag" constructor argument of the "craft\web\twig\nodes\GetAttrNode" class is deprecated Nov 14, 2024
@brandonkelly
Copy link
Member

Thanks for reporting that! Fixed now for the next Craft 4 and 5 releases.

@brandonkelly
Copy link
Member

Craft 4.13.3 and 5.5.1 are out with that fix. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants