Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x]: Extra space next to element action buttons #14885

Closed
mlathrom opened this issue Apr 27, 2024 · 2 comments · Fixed by #14898
Closed

[5.x]: Extra space next to element action buttons #14885

mlathrom opened this issue Apr 27, 2024 · 2 comments · Fixed by #14898
Assignees
Labels

Comments

@mlathrom
Copy link
Contributor

What happened?

Description

There's extra space next to the element action buttons on the entry pages. This is caused by the activity-monitor being empty, but having margin.

Steps to reproduce

  1. Click to create an entry.
  2. Scale screen down

Expected behavior

The action buttons should be flush.

Actual behavior

There's extra space when the activity-container is empty.

Screenshot 2024-04-26 223541
Screenshot 2024-04-27 163558

Craft CMS version

5.05

PHP version

8.2

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

@mlathrom mlathrom added the bug label Apr 27, 2024
@mlathrom
Copy link
Contributor Author

mlathrom commented Apr 27, 2024

Option 1

Simply remove the space. Keep button order.

PR: #14887

Screenshot 2024-04-26 223608

Option 2

Remove space, but also reverse the order of buttons. It feels right for the button order to be determined by which side they're aligned to.

PR: #14886

Screenshot 2024-04-27 163404

@brandonkelly
Copy link
Member

Thanks for reporting, and the PRs! Craft 5.1 is out with a similar solution to your second suggestion (#14898).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants